-
Notifications
You must be signed in to change notification settings - Fork 57
Mirror circuit fidelity estimation support and introduction of benchmarking interface (name TBD) #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndsieki
wants to merge
44
commits into
develop
Choose a base branch
from
feature-mcfe-integration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,599
−177
Open
Mirror circuit fidelity estimation support and introduction of benchmarking interface (name TBD) #628
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
3093bc2
Create branch feature-mcfe-integration with preliminary inclusion of …
ndsieki d2b1137
Resolve utils circular import
ndsieki 88a267e
remove outstanding unused utils import
ndsieki b89d1e2
Refactor Pauli RC and central pauli into RandomCompilation class
ndsieki 40b5711
Modify RandomCompilation for testing, add U3 and CNOT unit tests
ndsieki a48f2c2
add preliminary qiskit->pygsti circuit conversion utility and remove …
ndsieki 57a7e67
Add random compilation and central pauli unit tests
ndsieki 515a7e8
Add from_qiskit method to Circuit class
ndsieki 7afd5e2
Bugfixes to IBMQ interfacing and line ordering, add example notebook
ndsieki a5e5750
Subcirc selection now takes circ list instead of dict, mirror edesign…
45bea5d
fix typo in mirror edesign test-ref circuit matching assertion
ndsieki 0d66a82
Update from_qiskit() method to handle Qiskit circ with multiple qregs
57c7853
Factor MCFE VB process fidelity calculations into pyGSTi
ndsieki 9ad4941
Preliminary functionizations of notebooks for fullstack, subcirc, and…
ndsieki b696de9
More fixes and updates for MCFE paper
ndsieki c91b04f
Clamp PF estimates, modify full-stack mirror edesign creation to ensu…
ndsieki 18cf81d
add preliminary B-Sqale API
ndsieki 959468e
Merge remote-tracking branch 'origin/develop' into feature-mcfe-integ…
ndsieki 343643e
Add function documentation
ndsieki 6e5d5b9
Function renames and typo fixes
ndsieki c78453c
Repair central pauli code, fix unit tests
ndsieki 7ff81c6
Remove inline ipdb debug comments
ndsieki 5fc09e7
Finish vbdataframe docstrings
ndsieki ce59e72
Add docstrings and remove outdated code paths
ndsieki 664436b
Add qiskit conversion unit tests
ndsieki bd1428a
Add subcircuit selection unit tests
ndsieki 1c73dbf
Modify Gzr definition. Add unit tests for mirror circuit benchmarks.
ndsieki 0c36554
Add type annotations and missing docstring
ndsieki d071a75
Merge remote-tracking branch 'origin/develop' into feature-mcfe-integ…
ndsieki e459412
Type annotations
ndsieki 02cbc33
Move qiskit import outside of function for type annotation purposes
ndsieki dcb5cbe
Move B-Sqale into tools and rename functions
ndsieki 91a2f7d
Add previously missed type annotations
ndsieki 714d8d0
VBDataFrame bugfix and docstring correction
ndsieki 7bbed14
Replace Self type annotation to support Python 3.9, fix conversions b…
ndsieki e9ae6d1
Actually remove the typing.Self import
ndsieki 3816743
Merge remote-tracking branch 'origin/develop' into feature-mcfe-integ…
ndsieki d6b6491
Remove duplicate ECR conversion and fix CombinedExperimentDesign inhe…
ndsieki 919b398
Changes for Qiskit 2.1.1
ndsieki 57239e6
Fix subcirc selection to sample a new qubit subset for each subcircui…
ndsieki bc723b4
Fix variable name overlap
ndsieki 9533e83
Add copyright assertions, move import try-except statements into func…
ndsieki d248d98
Make verbose print statements more explanatory
ndsieki 2dbdd55
Add GenericBackendV2 as a supported type for `ibmq_backend` and fix f…
ndsieki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every other class that inherits from
Label
calls its corresponding functionreplace_name()
. CallingCircuit.replace_gatename()
would also return an error if any of the labels were of typeLabelTupWithArgs
due to this inconsistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!