Skip to content

Add types to gauge groups #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2025
Merged

Conversation

nkoskelo
Copy link

@nkoskelo nkoskelo commented Aug 5, 2025

This PR adds type information to the gauge groups file. This is part of an effort to make the code more readable.

@nkoskelo nkoskelo requested review from coreyostrove and removed request for a team August 5, 2025 21:28
@nkoskelo nkoskelo changed the base branch from master to develop August 5, 2025 21:30
Copy link
Contributor

@rileyjmurray rileyjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rileyjmurray
Copy link
Contributor

Looks like there are merge conflicts to be resolved, though.

@rileyjmurray
Copy link
Contributor

@nkoskelo
image

Please fix

@rileyjmurray rileyjmurray merged commit 9a3460f into develop Aug 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants