Skip to content

Upgrade manifest to v3 from v2 #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Upgrade manifest to v3 from v2 #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f116946
update manifest version
sanemat May 30, 2024
230f113
update the background property
sanemat May 30, 2024
e5a2699
use options ui
sanemat May 30, 2024
a04e0ba
update permissions
sanemat May 30, 2024
533003d
Merge branch 'master' into feat/manifest-v3
sanemat May 31, 2024
673073e
unnecessary permissions
sanemat Jun 16, 2024
d282eff
Merge remote-tracking branch 'origin/master' into feat/manifest-v3
sanemat Jun 16, 2024
5b4eea1
drop data migration code
sanemat Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,26 @@
{
"name": "__MSG_appName__",
"version": "3.0.1",
"manifest_version": 2,
"manifest_version": 3,
"description": "__MSG_appDescription__",
"icons": {
"16": "images/icon2-16.png",
"128": "images/icon2-128.png"
},
"permissions": [
"storage",
"storage"
],
"host_permissions": [
"https://github.com/*/*/pull/*"
],
"default_locale": "en",
"background": {
"scripts": [
"scripts/background.js"
],
"persistent": true
"service_worker": "scripts/background.js"
},
"options_ui": {
"page": "options.html",
"open_in_tab": true
},
"options_page": "options.html",
"content_scripts": [
{
"matches": [
Expand Down
25 changes: 0 additions & 25 deletions app/scripts/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,13 @@
// Define browser for cross-browser compatibility
var browser = (typeof browser !== 'undefined') ? browser : chrome;

function migrateLocalStorageToBrowserStorage() {
// Check if localStorage is not null and contains any keys
if (!localStorage || Object.keys(localStorage).length === 0) {
console.log('No localStorage data to migrate.');
return;
}

// Get all localStorage keys
const localStorageKeys = Object.keys(localStorage);
const dataToMigrate = {};

localStorageKeys.forEach((key) => {
dataToMigrate[key] = localStorage.getItem(key);
});

// Store data in broswer.storage
browser.storage.local.set(dataToMigrate, () => {
console.log('Data migrated to browser.storage', dataToMigrate);

// Clear localStorage after migration
localStorage.clear();
});
}

browser.runtime.onInstalled.addListener(function (details) {
if (details.reason === 'install') {
// Handle installation logic
console.log('Extension installed');
} else if (details.reason === 'update') {
console.log('previousVersion', details.previousVersion);
// Handle update logic
migrateLocalStorageToBrowserStorage();
}
});

Expand Down