-
Notifications
You must be signed in to change notification settings - Fork 2
refactor!: consistently separate ShareDataOps from NeighborValuesOps
#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 65.80% 65.79% -0.01%
==========================================
Files 49 48 -1
Lines 693 690 -3
Branches 58 57 -1
==========================================
- Hits 456 454 -2
+ Misses 237 236 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b93bf5c to
819e051
Compare
ShareDataOps from NeighborValuesOpsShareDataOps from NeighborValuesOps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused right now: why before we had "AggregateFoundation" and then "FieldBasedSharedData"?
e38c68b to
1835f1b
Compare
|
Hi @nicolasfara! 👋 |
This is because the Field-specific methods are now available as extension methods on the class FieldBasedSharedData. |
|
I would then not call that |
This PR fixes a trait clash caused by a previous refactoring where two
ShareDataOpstraits were defined with different aims.Rationale
AggregateFoundationdefines an abstractShareDatarepresenting a data structure produced in the context of an aggregate program. Such a data structure, according to this definition, is abstract. InShareDataOps, we provide two functionalities: one to retrieve the local value from such a structure, and one for getting the neighbors' values.In
FieldBasedShareDatasuchShareDatais further refined to the concept ofField. Indeed, it requires additional functionalities that are specified inNeighborValuesOps, which defines several methods to combine and operate with such a data structure.