Extend caching in the space engine beyond local context #23483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously isSubspace calls would be cached only as part of individual Space object, so when recursing through their ADT contents, we were not able to reuse the previously computed information. Now the cache is shared across the whole space engine run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously isSubspace calls would be cached only as part of individual Space object, so when recursing through their ADT contents, we were not able to reuse the previously computed information. Now the cache is shared across the whole space engine run.
Fixes #23317
The compilation of the problematic test now takes around 11 seconds, where previously a much simpler version (with 7 patterns as opposed to 9, with the complexity rising exponentially here) would take 113.75s (with the more complex versions taking too long to measure).
The issue is entirely caused by the reachability check, where the compiler seemed to visibly hang. I noticed that when checking if
Prod(List(QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_))))is a subspace ofOr(List(QuoteMatching.this.TypeMatch((_)), QuoteMatching.this.TypeMatch((_))) | List(QuoteMatching.this.TypeMatch((_))) | Nil)it would keep repeating comparisons ofProd(List(QuoteMatching.this.TypeMatch((_))))withOr(List(QuoteMatching.this.TypeMatch((_))) | List(QuoteMatching.this.TypeMatch((_)), empty))etc., inspiring the improvement here.