chore: make incremental compilation work with stdlib plugin and enable it in the new stdlib #23592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it in the new stdlib
hamzaremmal
commented
Jul 23, 2025
| // Update the timestamp in the analysis | ||
| stamps = stamps.markProduct( | ||
| VirtualFileRef.of(s"$${BASE}/$ref"), | ||
| Stamper.forFarmHashP(dest.toPath())) |
There was a problem hiding this comment.
I used this Stamper (forFarmHashP) based on observation and trials. It would be nice to have a confirmation if this is something stable or should a more developed logic be adopted here to choose the stampers.
hamzaremmal
commented
Jul 23, 2025
Gedochao
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main things here:
ScalaLibraryPluginto be able to work smoothly with the incremental compilationSome resources: