Skip to content

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Sep 15, 2025

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • abc

TODOs:

  • Right now, we delete all attachments that are referenced in the dataset. If two datasets reference the same attachments, they will still be deleted and the attachments will be unusable in the other dataset.
  • This deletion right now only works if all mags of a dataset are in controlled S3, it should probably work on layer or even mag level
  • do we still need to handle all symlink cases? (linked layer, linked mag, linked attachment)?
  • Delete as cleanup on failed dataset uploads
  • Allow manually deleting “Not yet fully uploaded” datasets (be it via publish or via upload)

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Added changelog entry (create a $PR_NUMBER.md file in unreleased_changes or use ./tools/create-changelog-entry.py)
  • Added migration guide entry if applicable (edit the same file as for the changelog)
  • Updated documentation if applicable
  • Adapted wk-libs python client if relevant API parts change
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases
  • Needs datastore update after deployment

Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch s3-delete

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frcroth frcroth assigned frcroth and unassigned frcroth Sep 17, 2025
@fm3 fm3 self-assigned this Sep 23, 2025
@fm3 fm3 changed the title Delete datasets on S3 WIP Delete datasets on S3 Oct 1, 2025
@fm3 fm3 mentioned this pull request Oct 2, 2025
18 tasks
Base automatically changed from s3-upload to master October 8, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete datasets from S3

4 participants