Skip to content

Conversation

knollengewaechs
Copy link
Contributor

@knollengewaechs knollengewaechs commented Sep 29, 2025

URL of deployed dev instance (used for testing):

Steps to test:

  • Open an annotation with multiple mags
  • Zoom out for a coarse mag
  • Brush anything using a big brush. You will need to change about 1000 buckets within 60s.
  • the warning toast should appear
  • Try clicking the toast away (without setting the "never show again")
  • try clicking "never show again". It should be supressed now.

TODOs:

  • user is able to click this away in one sesstion and forever
  • bucket threshold is in application.conf
  • share dev deplayment and ask for feedback, e.g. for threshold and false positives
  • remove magic numbers
  • find good place to store value of "dont show this again" -> dont show again for relation annotation&user? or only user? consider how annotation&user specific values are stores in live-is-live

Issues:

feedback:

https://scm.slack.com/archives/C5AKLAV0B/p1760367097181289


(Please delete unneeded items, merge only when none are left open)

  • Added changelog entry (create a $PR_NUMBER.md file in unreleased_changes or use ./tools/create-changelog-entry.py)
  • Added migration guide entry if applicable (edit the same file as for the changelog)
  • Updated documentation if applicable
  • Adapted wk-libs python client if relevant API parts change
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases
  • Needs datastore update after deployment

@knollengewaechs knollengewaechs self-assigned this Sep 29, 2025
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch encourage-coarser-mags-for-large-volume-annotations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

console.warn(warningMessage + " For more info, visit: " + linkToDocs);
}

console.log(`Save queue length: ${saveQueueLength}`, saveQueue);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dev change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce/encourage coarser mags when annotating large volumes

2 participants