Skip to content

Bugfix: HttpClient is not reused #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Bugfix: HttpClient is not reused #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tokens/src/main/java/io/scalecube/security/tokens/jwt/JwksKeyLocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public class JwksKeyLocator extends LocatorAdapter<Key> {
private final Duration connectTimeout;
private final Duration requestTimeout;
private final int keyTtl;
private final HttpClient httpClient;

private final Map<String, CachedKey> keyResolutions = new ConcurrentHashMap<>();
private final ReentrantLock cleanupLock = new ReentrantLock();
Expand All @@ -46,6 +47,7 @@ private JwksKeyLocator(Builder builder) {
this.connectTimeout = Objects.requireNonNull(builder.connectTimeout, "connectTimeout");
this.requestTimeout = Objects.requireNonNull(builder.requestTimeout, "requestTimeout");
this.keyTtl = builder.keyTtl;
this.httpClient = HttpClient.newBuilder().connectTimeout(connectTimeout).build();
}

public static Builder builder() {
Expand Down Expand Up @@ -75,12 +77,9 @@ private JwkInfoList computeKeyList() {
final HttpResponse<InputStream> httpResponse;
try {
httpResponse =
HttpClient.newBuilder()
.connectTimeout(connectTimeout)
.build()
.send(
HttpRequest.newBuilder(jwksUri).GET().timeout(requestTimeout).build(),
BodyHandlers.ofInputStream());
httpClient.send(
HttpRequest.newBuilder(jwksUri).GET().timeout(requestTimeout).build(),
BodyHandlers.ofInputStream());
} catch (HttpTimeoutException e) {
throw new JwtUnavailableException("Failed to retrive jwk keys", e);
} catch (IOException e) {
Expand Down