Skip to content

Fix/SK-000 | remove std::optional #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix/SK-000 | remove std::optional #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fednlib/grpc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class GrpcClient {
void setName(const std::string& name);
void setId(const std::string& id);
void setChunkSize(std::size_t chunkSize);
bool logMetrics(const std::map<std::string, float>& metrics, const std::optional<int> step=std::nullopt, const bool commit=true);
bool logMetrics(const std::map<std::string, float>& metrics, const int* step=nullptr, const bool commit=true);
bool sendModelMetrics(const std::map<std::string, float>& metrics,
const std::string& name,
const std::string& client_id,
Expand Down
6 changes: 3 additions & 3 deletions src/grpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,10 +889,10 @@ void sendIntervalHeartBeat(GrpcClient* client, int intervalSeconds) {
}


bool GrpcClient::logMetrics(const std::map<std::string, float>& metrics, const std::optional<int> step, const bool commit){
bool GrpcClient::logMetrics(const std::map<std::string, float>& metrics, const int* step, const bool commit){
// Add step and commit information if provided
if (step.has_value()) {
loggingContext.setStep(step.value());
if (step != nullptr) {
loggingContext.setStep(*step);
}
std::string roundId = loggingContext.getRoundId();
std::string modelId = loggingContext.getModelId();
Expand Down