fix(instance): EoS warning: filter product list by offer_id #3203
+1,648
−1,504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
force-pushed
the
instance_eos_filter_by_offer_id
branch
from
8994127 to
c1c011c
Compare
remyleone
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function to get the End of Service date of a commercial type to display a warning if it's about to be deprecated was filtering results from the Product Catalog according to the
productfield. But the content of this field might change in the future, whereas theoffer_idnested attribute will not, therefore we should use this field as a filter instead.This PR also removes a check where condition is always true.