fix(rdb): surface effective_permission and permission_status for privileges drifts #3429
+140
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
rdb
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3429 +/- ##
=========================================
- Coverage 1.76% 1.75% -0.01%
=========================================
Files 400 400
Lines 43836 43878 +42
=========================================
- Hits 774 772 -2
- Misses 42975 43018 +43
- Partials 87 88 +1 ☔ View full report in Codecov by Sentry. |
jremy42
force-pushed
the
fix/rdb-privilege-custom-drift
branch
3 times, most recently
from
70b63d8 to
3c503f1
Compare
…s; warn on drift; docs updated
jremy42
force-pushed
the
fix/rdb-privilege-custom-drift
branch
from
3c503f1 to
d53937d
Compare
estellesoulard
approved these changes
Oct 30, 2025
remyleone
reviewed
Oct 30, 2025
|
|
||
| var diags diag.Diagnostics | ||
|
|
||
| if effectivePermission != configuredPermission { |
Member
There was a problem hiding this comment.
Is there a way to add a test for this?
Contributor
Author
There was a problem hiding this comment.
Testing drift requires SQL executed outside Terraform, which is tricky to automate in acceptance tests :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2762