Skip to content

Conversation

BourgoisMickael
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.19%. Comparing base (15ac4c6) to head (fa29bc4).
⚠️ Report is 38 commits behind head on development/9.0.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/routeBackbeat.js 71.01% <100.00%> (+0.08%) ⬆️
@@               Coverage Diff                @@
##           development/9.0    #5898   +/-   ##
================================================
  Coverage            83.19%   83.19%           
================================================
  Files                  188      188           
  Lines                12093    12095    +2     
================================================
+ Hits                 10061    10063    +2     
  Misses                2032     2032           
Flag Coverage Δ
unit 67.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from improvement/CLDSRV-717-sproxyd to development/9.0 August 8, 2025 11:21
@bert-e
Copy link
Contributor

bert-e commented Aug 8, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 8, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Because it doesn't go through arsenal's normalizeRequest.
Do the same as for veeam route, to have the log field bytesReceived
This file is imported in tests used by S3C that have no
external location configured
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-s3c-tests branch from 151f12f to 2a258ce Compare August 14, 2025 13:44
@BourgoisMickael BourgoisMickael changed the base branch from development/9.0 to improvement/CLDSRV-717-unify-test-backbeat-route August 14, 2025 13:44
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-s3c-tests branch from 3198ee0 to db08c3e Compare August 14, 2025 14:53
- Reinclude some skip on tests and add new skips for tests not compatible with S3C
- Reinclude versionId encoded in queryObj for backbeat request
- Test backbeat api proxy conditional on config
- Factorize objMD update account info
- relication scenrio on same account + cross account
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch from 7902916 to 8a004c1 Compare August 14, 2025 15:01
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-s3c-tests branch from db08c3e to f3d1b78 Compare August 14, 2025 15:01
There is no account1 in mem_credentials, we use default
Replace hardcoded credentials so it can run in end to end tests
Replace hardcoded us-east-1 with a location from config
So it can run in an end to end tests for S3C
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch 3 times, most recently from 0bd3d47 to 4e4f7ff Compare August 27, 2025 11:37
Base automatically changed from improvement/CLDSRV-717-unify-test-backbeat-route to development/9.0 August 28, 2025 18:13
@BourgoisMickael
Copy link
Contributor Author

This has been split and merged into multiple PR

@BourgoisMickael BourgoisMickael deleted the improvement/CLDSRV-717-s3c-tests branch August 28, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants