Improvement/cldsrv 724 sur utapi tests #5950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
from
548afab to
4d4e5f0
Compare
❌ 366 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 71 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
3 times, most recently
from
3007608 to
5c9cd2c
Compare
As test files depend on these utilities, they needed to be adapted to match the sdk v3 requirements. Issue: CLDSRV-724
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-sur-utapi-tests
branch
from
fdd6e44 to
9844ffb
Compare
Comment on lines
+800
to
+802
| next => { | ||
| createBucket(bucket, false, next); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| next => { | |
| createBucket(bucket, false, next); | |
| }, | |
| next => createBucket(bucket, false, next); |
Comment on lines
+807
to
+808
| assert.ifError(err); | ||
| return next(); |
There was a problem hiding this comment.
not related to your changes but a quick win could be to just call the next with the error, because an assert in a cb makes it harder to debug, and can even hide the error (as we crash)
Comment on lines
+431
to
+433
| // Log what headers we're sending | ||
| // eslint-disable-next-line no-console | ||
| console.log('Request headers after stripping:', Object.keys(args.request.headers)); |
There was a problem hiding this comment.
We can probably remove this console log
| }); | ||
|
|
||
| // Add middleware to strip ALL checksum headers | ||
| s3Client.middlewareStack.add( |
There was a problem hiding this comment.
Can we maybe add a comment to explain why we need this? And maybe a ticket number if that could be removed, so we just support the standard headers
Comment on lines
+262
to
+264
| .catch(err => { | ||
| callback(err); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .catch(err => { | |
| callback(err); | |
| }); | |
| .catch(err => callback(err)); |
| if (!err && !s3Config.isQuotaInflightEnabled()) { | ||
| mockScuba.incrementBytesForBucket(bucket, parts * partSize); | ||
| if (!s3Config.isQuotaInflightEnabled()) { | ||
| mockScuba.incrementBytesForBucket(bucket, -(parts * partSize)); |
There was a problem hiding this comment.
i'm not sure to get why we increment the bytes before the call then we decrement them, is there any issue with the test?
Comment on lines
+154
to
+156
| .catch(err => { | ||
| cb(err); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .catch(err => { | |
| cb(err); | |
| }); | |
| .catch(err => cb(err)); |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
DarkIsDude
requested changes
Oct 2, 2025
Comment on lines
+16
to
+29
| if (unauthenticated) { | ||
| this.s3 = new S3Client({ | ||
| ...s3Config, | ||
| credentials: { accessKeyId: '', secretAccessKey: '' }, | ||
| forcePathStyle: true, | ||
| signer: { sign: async request => request }, | ||
| }); | ||
| } | ||
| else { | ||
| this.s3 = new S3Client({ | ||
| ...s3Config, | ||
| maxAttempts: 0, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (unauthenticated) { | |
| this.s3 = new S3Client({ | |
| ...s3Config, | |
| credentials: { accessKeyId: '', secretAccessKey: '' }, | |
| forcePathStyle: true, | |
| signer: { sign: async request => request }, | |
| }); | |
| } | |
| else { | |
| this.s3 = new S3Client({ | |
| ...s3Config, | |
| maxAttempts: 0, | |
| }); | |
| } | |
| if (unauthenticated) { | |
| s3Config = { | |
| ...s3Config, | |
| credentials: { accessKeyId: '', secretAccessKey: '' }, | |
| forcePathStyle: true, | |
| signer: { sign: async request => request }, | |
| }; | |
| } | |
| this.s3 = new S3Client({ | |
| ...s3Config, | |
| maxAttempts: 0, | |
| }); |
Pretty sure that maxAttempts: 0, is working also for unauthenticated client ?
Comment on lines
+80
to
+83
| return this.s3.send(new DeleteBucketCommand({ Bucket: bucketName })) | ||
| .catch(err => { | ||
| throw err; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| return this.s3.send(new DeleteBucketCommand({ Bucket: bucketName })) | |
| .catch(err => { | |
| throw err; | |
| }); | |
| return await this.s3.send(new DeleteBucketCommand({ Bucket: bucketName })); |
One good practice when working with async/await is to always await with return, this will help to preserve the full stack trace (without the await, the stack trace will start at the caller, if you put the await here, the stack trace will display deleteOne
| ) | ||
| .concat((data.DeleteMarkers || []) | ||
| .map(object => | ||
| this.s3.send(new DeleteObjectCommand({ |
| emptyMany(bucketNames) { | ||
| const promises = bucketNames.map( | ||
| bucketName => this.empty(bucketName) | ||
| const promises = bucketNames.map( |
| return Promise.all(promises); | ||
| } | ||
|
|
||
| emptyIfExists(bucketName) { |
There was a problem hiding this comment.
I think our guidelines ask us to add a new line between function definition ?
There was a problem hiding this comment.
good catch missed it here
| request.on('build', () => { | ||
| request.httpRequest.headers['x-scal-s3-version-id'] = vID; | ||
| }); | ||
| // Add custom header using middleware |
There was a problem hiding this comment.
Suggested change
| // Add custom header using middleware |
| } | ||
| cb(null, data); | ||
| }) | ||
| .catch(err => cb(err)); |
There was a problem hiding this comment.
Suggested change
| .catch(err => cb(err)); | |
| .catch(cb); |
Comment on lines
+154
to
+156
| .catch(err => { | ||
| cb(err); | ||
| }); |
Comment on lines
+377
to
+383
| .catch(err => { | ||
|
|
||
| if (!s3Config.isQuotaInflightEnabled()) { | ||
| mockScuba.incrementBytesForBucket(bucket, size); | ||
| } | ||
| return callback(err); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .catch(err => { | |
| if (!s3Config.isQuotaInflightEnabled()) { | |
| mockScuba.incrementBytesForBucket(bucket, size); | |
| } | |
| return callback(err); | |
| }); | |
| .catch(err => { | |
| if (!s3Config.isQuotaInflightEnabled()) { | |
| mockScuba.incrementBytesForBucket(bucket, size); | |
| } | |
| return callback(err); | |
| }); |
nits
| }), | ||
| next => { | ||
| putObject(bucket, key, size, err => { | ||
| assert.strictEqual(err.Code, 'QuotaExceeded'); |
There was a problem hiding this comment.
Same here, I'm not sure the callback will be called ?
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRV-724