-
Notifications
You must be signed in to change notification settings - Fork 249
Improvement/cldsrv 724 multiple backend tests #5960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: improvement/CLDSRV-724-kms-tests-migration
Are you sure you want to change the base?
Improvement/cldsrv 724 multiple backend tests #5960
Conversation
1769d66
to
4619bab
Compare
❌ 342 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 50 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
4619bab
to
76ab4cc
Compare
76ab4cc
to
fc9608c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments as the pr was listed for review (but still a draft)
otherwise lgtm, some patterns could be simplified, when calling the next
functions (by removing the {} or the =>)
throw new Error('Expected NoSuchKey error but got success'); | ||
} catch (err) { | ||
assert.strictEqual(err.code, 'NoSuchKey'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as you throw in the try, that we will enter the assert of the catch and fail the check, then we loose the inital error you thrown, and we'll see an asert failure with "undefined" that is not "NoSuchKey", can be misleading
(same other places)
.then(() => { | ||
done(new Error('Expected failure but got success')); | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.then(() => { | |
done(new Error('Expected failure but got success')); | |
}) | |
.then(() => done(new Error('Expected failure but got success'))) |
it('should delete object from AWS location with bucketMatch set to ' + | ||
'false', done => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test was removed, is this expected?
Issue: CLDSRV-724