-
Notifications
You must be signed in to change notification settings - Fork 55
Clarify the SPEC process: scope, procedure #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the SPEC process: scope, procedure #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these feels like great improvements. I have some minor comments.
Co-authored-by: Brigitta Sipőcz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed reads better, thank you!
Thanks!! I am on vacation until Monday, so I just took a quick scan. I will do a more careful review then. It would be worth trying to get as many steering committee members approving this as possible. Just to make sure we are all on the same page. You may want to review
to make sure those sections are in sync with these changes. Also may be worth making sure the information isn't duplicated by linking from here to this page or vice versa. |
Probably best to work with #393 and update the quickstart script to address the limitations of the PR template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Thanks!
Question: This document does not say what happens if a SPEC proposal is rejected; did I miss it elsewhere?
There is also issue with the flowchart in dark mode but I will open separate issue for that (#396) as dark mode is out of scope here.
Also see inline comments from SPEC meeting notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failures looks relevant this time, the links don't resolve as expected. Maybe use {ref}`ref-name`
syntax instead?
3ce8288
to
051ad80
Compare
There's still some duplication, but it is now clearly marked. See 051ad80 |
51bd88d
to
3b4de89
Compare
I don't know if we have anything specific to say on this situation. Two reasons for rejection are:
Perhaps the SPEC committee here uses their best judgment. |
OK, should be ready for another round of review. |
This looks to be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Stefan!
This PR aims to clarify the SPEC process to make it very clear to new contributors what the procedures are for submitting a SPEC, as well is what is, and is not, in scope for a SPEC.
/cc @scientific-python/spec-steering-committee