- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.3k
[MRG] Better in-out support #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Better in-out support #681
Conversation
| Codecov Report
 @@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   98.59%   98.65%   +0.05%     
==========================================
  Files          82       82              
  Lines        4850     4907      +57     
==========================================
+ Hits         4782     4841      +59     
+ Misses         68       66       -2
 Continue to review full report at Codecov. 
 | 
e77b8ab    to
    35d7af9      
    Compare
  
    | This pull request introduces 1 alert when merging 35d7af9 into 3ede269 - view on LGTM.com new alerts: 
 | 
| This pull request introduces 1 alert when merging 182dc6e into 3ede269 - view on LGTM.com new alerts: 
 | 
| @glemaitre I think that there is no need to attach that object to the the sampler instance. So, when you have time check again. | 
| This is good | 
| Arfff I forgot to check the what's new. Could you make an entry in what's new in 0.6.2 | 
| @glemaitre see #682 and update it if you want. | 
Reference Issue
Follows #673. Fixes #666.
What does this implement/fix? Explain your changes.
Adds better support for pandas and simple lists, if this is the case.
Gradually we could support more array data types.
Any other comments?
I created new type for the job just to keep some state.
The intention is to be private, thus no tested are provided.Existing tests are passing, at least on my machine. Let's see what the CIs think.