refactor(eventfilter): shared fileloader with scheduler-based ringbuf… #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer; unify event check logic; fix nccltimemout detection - Refactor FileFilter: - Decouple file loading via shared FileLoader and centralized FileLoaderScheduler - Each EventFilter maintains its own read pointer, reading from ring buffer - returns structured Result with matched event info - Refactor event-based checkers: - Remove redundant Collector and Checker modules - Use EventFilter.Check() directly and integrate with spec-based check result - Fix NCCL event detection: - change nccl componet to podlog componet, provides more reusable event matching behavior from pod log - Only check event from logs of running pods - Fix version print - move nccl perftest to infiniband perftest
xlliu-scitix
force-pushed
the
feat/refactor-eventfilter
branch
from
77ce817 to
868c4f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fer; unify event check logic; fix nccltimemout detection
Refactor FileFilter:
Refactor event-based checkers:
Fix NCCL event detection:
Fix version print
move nccl perftest to infiniband perftest