Jb43 Unable to process GIF MMS file #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating features from CM7 to CM9 - http://review.cyanogenmod.com/#change,3316,patchset=1 Change-Id: I05f134e22f5f186dbb5c07bbb14e4489a2a27f9b
Migrating features from CM7 to CM9 - http://review.cyanogenmod.com/#change,6576,patchset=2 Change-Id: I52f806c6347450ec8b91cdf053d4951511805f7e
Patch Set 1: SMS Templates Patch Set 2: Custom Vibrations Patch Set 3: Timestamp Options Patch Set 4: Fix crash when vibrate preference is not set. Patch Set 5: Remove SMS split preference and replace with config option Patch Set 6: Fix SMS Split logic Attributions - Patch Set 1 + SMS templates using gestures (rciovati) + Change-Id: Idfa1fc08b123680bb2113b7e6ee90fc53040a972 - Patch Set 2 + Custom vibrate patterns, kanged in from 855fd19 by Wes Garner (mssmison) + Change-Id: I5da9d4f075b8c273f6e84c75c2566c658bfcd897 - Patch Set 3 + Show full timestamps (jonasl) + Change-Id: I7ba1d5b83c99d0037cd94bb53151bd2e9ec60fe8 + Display original SMS timestamp instead of reception date (aravance) + Change-Id: I38cb7ad930acb6d865df60c792020a946aaec06c + Fix sent SMS timestamp display (burnsra) + Change-Id: I1d52cb46cc804a38212b8605022f2d04384ced01 - Patch Set 4 + Fix Mms app crash when vibrate preference has not been set (gamblore) + Change-Id: I21783cd770ffa8301ed67eddb338b6cec05ab0cc - Patch Set 5 + Remove SMS split preference and replace with config option (nullghost) + Change-Id: I3c658a562439a5d4ef7c8b957fbea6eddc509818 Change-Id: Iefb57b35a77ff3eca5c5f41cc60f7074ff562d15
Support for the Unicode subset dedicated for emojis, as used on the iPhone, or even the Gmail website. The full list with Unicode codes is available here: http://barrow.io/posts/iphone-emoji/. The pictures used here are not bound to any licenses, even GitHub is using them (https://github.com/blog/816-emoji). The size of the icons seems OK to me, but I could only test on an HDPI device (Galaxy S II i9100). MDPI icons are also included, but I couldn't really test it. A new checkbox preference has been added to be able to toggle the feature. The feature will be disabled if the "Strip Unicode" feature is enabled (obviously). PS1: Initial commit PS2: pngcrush on all the pictures + XHDPI emojis PS3-7: Fixed indentation and removed useless whitespaces Change-Id: I8a457498fb655ea3f1bb273d7756f7c224b81466
PS1: Initial
PS2: Rebase for merge
PS3: Fix duplicate characters with some keyboards
Option which attempts to substitute characters that cannot
be encoded in the limited GSM 03.38 character set. In many
cases this will prevent the keyboards auto-correction
feature or copy/paste from inserting characters that would
switch the message from 7-bit GSM encoding (160 char limit)
to 16-bit Unicode encoding (70 char limit).
This is ready for use with simple alphabets like Spanish
and French, but may need extra special cases for languages
which use unusual characters.
Unfiltered characters:
demo.icu-project.org/icu-bin/convexp?conv=gsm-03.38-2000
Auto-filtered characters:
Aesthetic ligatures like ff
Anything with an accent on this table;
unicode.org/charts/PDF/U0300.pdf
Special cases so far:
Π-> OE
œ -> oe
Change-Id: Ibec615edd371a040a56dd04904218594e851dbd8
Needed in Polish. (Mentioned by yaatzek on XDA.) Change-Id: I1cec637704f4e2f1496d047ed820f1b92b2f9f5a
Replaces lower-case and upper-case Greek characters to their equivalent upper-case English and Greek (where applicable) characters. Change-Id: I4b7f2b463086a68c711fecf4cee29ffc3f7947a2
…x, and Better dialog for insertion My previous patch used the Softbank private unicode code page to encode and decode emojis. PROBLEM: This was the technique used by iOS before version 5 and all the Japanese carriers. Google and Apple have proposed a new code page which has been integrated into Unicode 6.0, then updated in 6.1 The full specification can be found here: http://www.unicode.org/~scherer/emoji4unicode/snapshot/full.html SOLUTION: This patch changes the way emojis are encoded and adds a new decoding table, but keep both for compatibility. Surrogate pairs are used, because of the way Java handles UTF-16 chars - these cannot be included in the XML resource file. I also changed the strings to respect UI guidelines, and extended the dialog so users can add more than one emoji. PS1: Initial patch PS2/3/4: Fixed typos in the Softbank codes PS5: Fix the 'Emoji support' setting toggle which used to disable only Emoji encoding, but not decoding PS6/7: XML layout for the 'Insert emojis' dialog Change-Id: I9eb5081eb7514cb2b89ed3b91cc3054347d6ac90
… messages This commit gives the user the option to change the keyboard from Emoji to enter for a new line or enter to send. The setting has no effect on the hardware keyboard. Change-Id: I8c794da09e27ef48eb0111afc1d3c3c53219bf87
Migrating features from CM7 to CM9 - http://review.cyanogenmod.com/#change,3316,patchset=1 Change-Id: I05f134e22f5f186dbb5c07bbb14e4489a2a27f9b
…lenght of the message is > 3 sms. It is also possible to still have this transformation but to change the number of text needed before the sms is transformed to mms EN, FR, DE and SV translation included (thanks to Markus Hoeber for DE and Björn Lundén for SV) Patch Set 1 : code Patch Set 2 : Tabulation removed Patch Set 3 : German translation added Patch Set 4 : English strings corrected Patch Set 5 : Swedish translation added, trailing spaces removed Change-Id: I9d2f2eea29587c07b790c0f8055cb703bdfd2463
- Screenshot / http://www.robertburns.me/android/cyanogenmod/Screenshot_2012-07-29-08-23-10.png Change-Id: I6b9f0e850fdef204f3b848f997568da66fa84166
This patch fix a wrong selection of the sms template when the user performs two different gestures Change-Id: I4e9d15fc779f6a270421f78c4aed3cd90c0cd01d Signed-off-by: Riccardo Ciovati <[email protected]>
Initial commits for Uighur language Depends: http://r.cyanogenmod.com/#/c/19818/1 Credits: Abduqadir Abliz Patch 2: Remove trailing whitespaces Change-Id: I63e87382fa7f4aca96e9c393144bd78818170724
The code wasn't updated for ICS everywhere so it points to old upscaled Gingerbread drawables in a few places. Change-Id: I8224c6cce285d42fa0ba3317367a0b025050a83c
Change-Id: I3115ec2186403d3b4748815ae2a509300b983818
Remove obsolete translation entries Patch 2: Title typo Change-Id: Ie54ed84d329cf88e99356438d12466f1ddae85bb
…brate only The actual code uses getRingerMode() to determinate the silent mode. This mode can take 0-Silent, 1-Vibrate, 2- Normal. But sound settings and sound widget can configure 4 states (between brackets the value assigned by getRingerMode()): Ring (2), Ring+Vibrate (2), Silent (0) and Vibrate (1) When an sms is received and the apps makes the check if need do vibration, ring+vibrate is not "silent" and vibration is not used. This change used shouldVibrate applied to "always" setting. Now the model is the next: On setting "Always" Ring: false Ring+Vibrate: true Silent: false Vibrate: true On setting "Only on Silent" Ring: false Ring+Vibrate: false Silent: false Vibrate: true Patch 3: Surround brackets Change-Id: Ie43dfa7576fd21dc5d01426119ce28646f39471a
When a user receives an Mms and there is no more pending requests, the method endMmsConnectivity() is called to turn the data connection off and clear the wakelock. Sometimes the phone deep sleeps before the user gets Mms notifications, so this patch makes endMmsConnectivity() to be the last operation so users can be notified of Mms's. Change-Id: Id6f2ce22d7d658a21d482cbe4220de7c88510466
it is not consistent that the sender text is now holo light blue dues that the entered text from the user is white. Switch it back to old behaviour so entered text color is the same like senders color and received sms color back to holo light blue Change-Id: I0c2bfa19a143d6275d8433437fe2cf80586ccaa9
The pager must be notified of changes in its underlying data. JIRA:CYAN-1703 Change-Id: I473e03e546665f5a159e2af43b389c0d83dc9928
* use mwi to disable the 9016 Change-Id: I7177bff8970c07fef5e33b3fe06656b758bfcf97 Signed-off-by: scotthartbti <[email protected]> Conflicts: src/com/android/mms/MmsConfig.java
findPart updated to include looking in ContentId even if the "src" does not have the cid: prefix. Noticed from a Stock GS4. SmilHelper now has a fixup(...) method which removes duplciate parts. Change-Id: I1e1b6b0792888797123fadd795dd33b141ce8ea2
This reverts commit f1cc3d5.
* use mwi to disable the 9016 Change-Id: I7177bff8970c07fef5e33b3fe06656b758bfcf97 Signed-off-by: scotthartbti <[email protected]> Conflicts: src/com/android/mms/MmsConfig.java
Android 4.3 release 2.1 Change-Id: I71ad49869eef0f9e77917b54705620f363d21157 Signed-off-by: scotthartbti <[email protected]> Conflicts: src/com/android/mms/ui/ConversationList.java
…ist" This reverts commit 64227b7.
This reverts commit e23ac44. Signed-off-by: scotthartbti <[email protected]> Conflicts: res/xml/preferences.xml src/com/android/mms/ui/MessagingPreferenceActivity.java Change-Id: I820029b60a8430cc087e2cb3943684e4aa7750fb
Change-Id: Ib809ea56de60b6eace785ffd69158b10c2c9ebbe Signed-off-by: scotthartbti <[email protected]> Conflicts: res/xml/preferences.xml src/com/android/mms/ui/ComposeMessageActivity.java src/com/android/mms/ui/MessagingPreferenceActivity.java
Signed-off-by: scott <[email protected]> Change-Id: Id5b111fae945d2546974c7982dbb694d7064e77f
This reverts commit fb113cc.
The original code has not catched "Unsupported Content-Type" exception resulting in force close if an mms containing an unsupported content type is opened. Change-Id: I9b578e2fd61ba5df9dbfbe9e6e28fb276ef89666 Author: Haixiong Zheng <[email protected]> Signed-off-by: Jeevaka Badrappan <[email protected]> Signed-off-by: Bin Yang <[email protected]> Signed-off-by: Shuo Gao <[email protected]> Signed-off-by: Bruce Beare <[email protected]> Signed-off-by: Jack Ren <[email protected]> Author-tracking-BZ: 5339
Change-Id: If5d995c32aad71695c15a9a2a781d20312416a79 Signed-off-by: Roger Chen <[email protected]>
when the UriImage resize the picture. It will not close the InputStream and OutputStream. Change-Id: I80fa1eb3726308fe75d74357e0b9782759de3393 Author: Jianping Li <[email protected]> Signed-off-by: Jianping Li <[email protected]> Signed-off-by: Hongyu Zhang <[email protected]> Signed-off-by: Frederic Predon <[email protected]> Signed-off-by: Shuo Gao <[email protected]> Signed-off-by: Bruce Beare <[email protected]> Signed-off-by: Jack Ren <[email protected]> Author-tracking-BZ: 28037
testcase 1> create a slideshow mms and play it. Tap progress bar
continuously until play finished.
2> create a slideshow mms and play it. Tap progress bar
continuously when rotate the screen
We have to set the seek bar change listener to null,otherwise if
the activity stop during tap progress bar continuously, window
will leak.
Change-Id: I206d35b91e04de06c2073c3fb0d9176da6adc81c
Author: Frederic Predon <[email protected]>
Signed-off-by: b533 <[email protected]>
Signed-off-by: Frederic Predon <[email protected]>
Signed-off-by: Bin Yang <[email protected]>
Signed-off-by: Shuo Gao <[email protected]>
Signed-off-by: Bruce Beare <[email protected]>
Signed-off-by: Jack Ren <[email protected]>
Author-tracking-BZ: 28634
Upon Send SMS failure due to destination number or service center number not present in the FDN list, failure is not notified to the MessageNotification. Due to this Sms remains in Sending state even after the SMS send has failed. This patch fixes the issue by notifying the message failure and also moving the message to respective folder. Change-Id: I1f8dfe2d9b276c8c6f4d921c2c147a8ef90643e6 Author: Jeevaka Badrappan <[email protected]> Signed-off-by: Jeevaka Badrappan <[email protected]> Signed-off-by: Shuo Gao <[email protected]> Signed-off-by: Bruce Beare <[email protected]> Signed-off-by: Jack Ren <[email protected]> Author-tracking-BZ: 48558
Default is off, option stored in the app settings. Change-Id: Id3da2656da44e5051d4b36bf064db83faf919b5d Signed-off-by: Dan Trifan <[email protected]> Signed-off-by: scott <[email protected]> Conflicts: res/values/strings.xml res/xml/preferences.xml Conflicts: res/values/strings.xml res/xml/preferences.xml
For tablet we usually declare not support mobile_* networkAttributes but ethernet, wifi,bt in config.xml. this will trigger this NPE. Change-Id: I761c8514f5569bef1242f9fddc321c0aed564d9e Signed-off-by: Jianzheng Zhou <[email protected]>
Need to handle IllegalStateException in addition of the MMSException when creating draft MMS. Change-Id: Ieb1618872d7faa472a6fea08c1b3ef1ae0cde183 Author: Jianli Zhang <[email protected]> Signed-off-by: Frederic Predon <[email protected]> Signed-off-by: Xiaokang Qin <[email protected]> Signed-off-by: Beare, Bruce J <[email protected]> Signed-off-by: Jack Ren <[email protected]> Author-tracking-BZ: 7844
In case there is no image and no video in the slideshow, the media model might be null. Add a check to avoid a null pointer access. Change-Id: I55d63b226835acfa53199eee0d706b8c5ae553c2 Author: Hongyu Zhang <[email protected]> Signed-off-by: Hongyu Zhang <[email protected]> Signed-off-by: Frederic Predon <[email protected]> Signed-off-by: Shuo Gao <[email protected]> Signed-off-by: Bruce Beare <[email protected]> Signed-off-by: Jack Ren <[email protected]> Author-tracking-BZ: 28037
Rootcause: If the address contains spaces only,when Mms format this address,it will get an address string the length of which is -1. So crash happen when call span(object,0,-1,flag) function. Solution: When user press back key to restore the message. This patch will check the address is valite or not, if it is invalite,it show a dialog to tell user he can't restore the message. So it avoid crashing when enter the message again. Change-Id: Ia847ee6a7c9666376ea6fcc56d18105e6e5474a7 Author: Jianping Li <[email protected]> Signed-off-by: Jianping Li <[email protected]> Signed-off-by: Shuo Gao <[email protected]> Signed-off-by: Bruce Beare <[email protected]> Signed-off-by: Jack Ren <[email protected]> Author-tracking-BZ: 56634
If user starts typing a reply in the QuickMessage Popup, and another msg arrives, the entered text was wiped. This commit saves the current reply text, before adding/updating the new message, so that is doesn't get lost Change-Id: I7aa4a488b233ed7554ec589fae0d615b18e3502c
Previous commit, prevented QuickMessage text from disappearing, but was leaving the keyboard open, so user could continue to type. Unfortunately, the EditText loses focus (not sure if that can be changed?), so the typed text goes nowhere and causes confusion. This commit will hide the keyboard, so user will need to reselect the EditText field first to redisplay the keyboard and continue typing. Change-Id: I4869392b16be015ab9a8cd99bf3f95f0e86b74ad
Doing so allows bypassing the lockscreen. Change-Id: I8a49395954ba1e50415285531ebe75e2c4343c1c
The old code generates ACTION_CALL intents with content uris instead of tel
ones, and this causes the SipCallOptionHandler not to be triggered, forcing
the call to be routed via the mobile network instead of following the user
configuration and potentially asking if SIP should be used.
Old intent:
D/CallController( 1204): placeCall()... intent = Intent { act=android.intent.action.CALL dat=content://com.android.contacts/data/phones/12345 (has extras) }
New intent:
D/CallController( 1204): placeCall()... intent = Intent { act=android.intent.action.CALL dat=tel:xxxxxxxxxxx-xxxx (has extras) }
Change-Id: Iba0134af51edb092913636ba9f51a6a344acb436
Instead of launching another activity just to show the delivery report, mimic how showMessageDetails works instead, using AlertDialog.Builder. This ports the dialog over to Holo as well. Change-Id: Ia7ee549fe7ed9770a70482a042ebbc4bc12bab21 Signed-off-by: angelsl <[email protected]>
Signed-off-by: scott <[email protected]> Conflicts: src/com/android/mms/data/Conversation.java src/com/android/mms/transaction/MessagingNotification.java src/com/android/mms/transaction/MmsSystemEventReceiver.java src/com/android/mms/ui/MessageListItem.java Change-Id: I40ab95f8405084ca3ded5fa35751cf965643fc6d
Signed-off-by: scott <[email protected]> Change-Id: Ia9df283a1e363fad08c6e93dc5e5c5d5e5ff699a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sir,
I am unable to play GIF MMS animation images on sideview it is displaying only single image. so please help me.
Thanks
anurag