Skip to content

fix: allow 'N {interval} from now' (#502) #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow 'N {interval} from now' (#502) #1271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dateparser/data/date_translation_data/en.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,7 @@
"and",
"at",
"by",
"from",
"just",
"m",
"nd",
Expand Down
2 changes: 1 addition & 1 deletion dateparser_data/supplementary_language_data/date_translation_data/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
skip: ["about", "ad", "and", "at", "by", "just", "m", "nd", "of", "on", "rd", "st", "th", "the"]
skip: ["about", "ad", "and", "at", "by", "from", "just", "m", "nd", "of", "on", "rd", "st", "th", "the"]
pertain: ["of"]

sentence_splitter_group : 1
Expand Down
5 changes: 5 additions & 0 deletions tests/test_freshness_date_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ def test_relative_past_dates_with_time_as_period(self, date_string, ago, period)
period="day",
),
param("just now", ago={"seconds": 0}, period="day"),
param('11 hours from now', in_future={'hours': 11}, period='hour'),
param('10 days from now', in_future={'days': 10}, period='day'),
param('9 weeks from now', in_future={'weeks': 9}, period='week'),
param('8 months from now', in_future={'months': 8}, period='month'),
param('7 years from now', in_future={'years': 7}, period='year'),
# Fix for #291, work till one to twelve only
param("nine hours ago", ago={"hours": 9}, period="day"),
param("three week ago", ago={"weeks": 3}, period="week"),
Expand Down