Skip to content

Conversation

starrify
Copy link
Member

Resolves #276

@codecov-io
Copy link

Codecov Report

Merging #277 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   91.36%   91.45%   +0.08%     
==========================================
  Files          30       32       +2     
  Lines        1957     1977      +20     
==========================================
+ Hits         1788     1808      +20     
  Misses        169      169
Impacted Files Coverage Δ
shub/tool.py 95% <ø> (ø) ⬆️
shub/jobmeta.py 100% <100%> (ø)
shub/stats.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e5b41...52eb0bf. Read the comment docs.

@jdemaeyer
Copy link
Contributor

Hi Pengyu, thanks a lot for this PR. :)

I had refrained from merging this so far because I would like to unify all the job-related commands under a shub job umbrella, hosting these two new commands as well as items, log, and requests.

However, now I think we should just get this out there and then work on the shub job umbrella for the next major release. Code LGTM, are there any last-minute concerns that riped over the last months from you? ;)

@starrify starrify force-pushed the add-stats-metadata branch from 52eb0bf to d846b0b Compare July 1, 2020 13:14
@rafaelcapucho rafaelcapucho force-pushed the master branch 2 times, most recently from a290a34 to b0e4614 Compare January 15, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[idea] Support retrieving job stats / metadata

3 participants