macOS Sequoia+ Private Wifi Address Fix #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes * Fixed MAC address resolution for macOS Sequoia+ to correctly handle private Wi-Fi addresses by introducing a platform-specific check for macOS with release version 24 or higher. * Added a new module for macOS (`getmacaddress_darwin.js`) to resolve MAC addresses using the `networksetup` utility. Affected Files * `index.js` * `lib/getmacaddress.js` * `lib/platform/getmacaddress_darwin.js`
…fconfig before it.
…s module and running getmacaddress if on macOS Sequoia+. This fixed all the issues of returning the wrong mac address when testing test.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getmacaddress_darwin.js) to resolve MAC addresses using thenetworksetuputility.Affected Files
index.jslib/getmacaddress.jslib/platform/getmacaddress_darwin.js