feat: enable set multiple blob provider #305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
reviewed
Sep 10, 2025
jonastheis
reviewed
Sep 15, 2025
jonastheis
reviewed
Sep 15, 2025
| } | ||
| Err(err) => { | ||
| debug!(target: "scroll::providers", ?hash, ?block_timestamp, ?provider_index, ?err, provider_type, "provider failed to fetch blob"); | ||
| counter.store(provider_index + 1, Ordering::Relaxed); |
There was a problem hiding this comment.
now this means we will always just use the same provider until it fails. why not just always rotate independently whether it succeeds/fails. then we do truly round robin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable RN to set multiple blob providers, and round robin provides. This will increase stability.
There is a priority order:
Corresponding issue: #262