-
Notifications
You must be signed in to change notification settings - Fork 5
feat: improve UpdateFcsHead to add reverted transations to tx pool #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #406 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added some comments inline.
|
Can we also update the logic for the rollup-node/crates/chain-orchestrator/src/lib.rs Lines 358 to 368 in e9cff2d
|
Sure, added in commit 24cad17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR enhances L2 block reorg handling. When a reorg occurs, we:
This ensures that reverted but valid transactions are not lost and may be included in future blocks.
Corresponding issue: #352
closes: #320, #352