privacy: don't leak origin via referer header #4295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slydetector
requested review from
OwsleyJr,
TheCatLady,
danshilm and
sct
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overseerr web-ui leaks the origin site URL via the
Refererhttp request header when loading resources from some 3rd party websites. Examples include:https://plex.tv/users/<redacted>/avatar?c=<redacted>https://fonts.gstatic.com/s/inter/v20/UcC73FwrK3iLTeHuS_nVMrMxCp50SjIa1ZL7W0Q5nw.woff2https://secure.gravatar.com/avatar/<redacted>?d=<redacted>I've got image caching enabled atm, but when disabled, loading images from tmdb & friends also leaks the origin via referer header.
Unless the referrer header is necessary for correct functionality, it would be a good idea to set a site wide referrer policy to
no-referrerin the interest of privacy.Tested with the change I'm not seeing the referer header being sent anymore.