fix: prevent settings from being overwritten on load (#4291) #4299
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove automatic save call in Settings.load() method that was causing notification settings (particularly webhook URLs) to be unexpectedly overwritten after server restarts. The load() method was automatically saving settings after merging with defaults, which could cause user configurations to be replaced with default or previously cached values due to the merge behavior. Fixes sct#4291
AmGarera
requested review from
OwsleyJr,
TheCatLady,
danshilm and
sct
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove automatic save call in Settings.load() method that was causing notification settings (particularly webhook URLs) to be unexpectedly overwritten after server restarts.
The load() method was automatically saving settings after merging with defaults, which could cause user configurations to be replaced with default or previously cached values due to the merge behavior.
Fixes #4291
Description
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed