Skip to content

Conversation

frieseneggerf
Copy link
Contributor

@frieseneggerf frieseneggerf commented Oct 13, 2025

Hello, I noticed that pl.repertoire_overlap() ignores the "airr_mod" keyword.
The problem appears to be fixed by passing "params" instead of "adata" during the implicit call of tl.repertoire_overlap().

  • CHANGELOG.md updated
  • Tests added (For bug fixes or new features)
  • Tutorial updated (if necessary)

Fix wrongly passing adata instead of params to tl.repertoire_overlap() which causes airr_mod to be ignored
@frieseneggerf frieseneggerf changed the title Update _repertoire_overlap.py Fix airr_mod being ignored by pl.repertoire_overlap() Oct 13, 2025
@grst grst enabled auto-merge (squash) October 18, 2025 18:38
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.30%. Comparing base (6abf5ba) to head (b287c32).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #650       +/-   ##
===========================================
- Coverage   79.26%   19.30%   -59.96%     
===========================================
  Files          51       51               
  Lines        4576     4604       +28     
===========================================
- Hits         3627      889     -2738     
- Misses        949     3715     +2766     
Files with missing lines Coverage Δ
src/scirpy/pl/_repertoire_overlap.py 17.10% <ø> (-27.64%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grst grst merged commit bab86f8 into scverse:main Oct 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants