Skip to content

Conversation

dkropachev
Copy link

@dkropachev dkropachev commented Oct 7, 2025

  1. Move all CICD code into a Makefile.
  2. Update all workflows to use Makefile.

@dkropachev dkropachev force-pushed the dk/add-makefile branch 5 times, most recently from 5d5c958 to 275e75e Compare October 8, 2025 11:38
@dkropachev dkropachev force-pushed the dk/add-makefile branch 5 times, most recently from 995a5e2 to cdb1fc3 Compare October 9, 2025 21:12
@dkropachev dkropachev marked this pull request as ready for review October 9, 2025 21:41
@dkropachev dkropachev requested a review from Bouncheck October 9, 2025 21:43
Copy link

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some code comments

Move all CICD code into a Makefile.
Update all workflows to use Makefile.
Copy link

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.
Additional things to consider:

  • Some documentation on how to use the makefile
  • Looks like this is also preparing for switch to cassandra-ccm for cassandra integration tests. In such case note that the user will have to reinstall ccm each time he switches between integration testing with scylla and IT with cassandra. On CI this works because we're using clean runners for each run. On local machine I'm not sure if this is guaranteed to work. If the reinstallation correctly overwrites what's important then it will, but it still would be nicer not having to reinstall the tooling. I don't know if those two variants of ccm can coexist. It will require a custom setup.

@dkropachev
Copy link
Author

  • Looks like this is also preparing for switch to cassandra-ccm for cassandra integration tests. In such case note that the user will have to reinstall ccm each time he switches between integration testing with scylla and IT with cassandra. On CI this works because we're using clean runners for each run. On local machine I'm not sure if this is guaranteed to work. If the reinstallation correctly overwrites what's important then it will, but it still would be nicer not having to reinstall the tooling. I don't know if those two variants of ccm can coexist. It will require a custom setup.

Actually it tracks which ccm is installed and installs correct one.

@dkropachev dkropachev merged commit b088d67 into scylladb:scylla-4.x Oct 13, 2025
10 checks passed
@Bouncheck
Copy link

  • Looks like this is also preparing for switch to cassandra-ccm for cassandra integration tests. In such case note that the user will have to reinstall ccm each time he switches between integration testing with scylla and IT with cassandra. On CI this works because we're using clean runners for each run. On local machine I'm not sure if this is guaranteed to work. If the reinstallation correctly overwrites what's important then it will, but it still would be nicer not having to reinstall the tooling. I don't know if those two variants of ccm can coexist. It will require a custom setup.

Actually it tracks which ccm is installed and installs correct one.

It seems to me that ccm-type holds only 1 version type at a time.
If it does not match then it installs.
I'm not sure how pip behaves when you install both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants