-
Notifications
You must be signed in to change notification settings - Fork 39
cicd: move all cicd code into a Makefile #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d5c958
to
275e75e
Compare
995a5e2
to
cdb1fc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some code comments
Move all CICD code into a Makefile. Update all workflows to use Makefile.
cdb1fc3
to
3b5780b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok.
Additional things to consider:
- Some documentation on how to use the makefile
- Looks like this is also preparing for switch to cassandra-ccm for cassandra integration tests. In such case note that the user will have to reinstall ccm each time he switches between integration testing with scylla and IT with cassandra. On CI this works because we're using clean runners for each run. On local machine I'm not sure if this is guaranteed to work. If the reinstallation correctly overwrites what's important then it will, but it still would be nicer not having to reinstall the tooling. I don't know if those two variants of ccm can coexist. It will require a custom setup.
Actually it tracks which ccm is installed and installs correct one. |
It seems to me that |
Uh oh!
There was an error while loading. Please reload this page.