Skip to content

tests: change test tag logic #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

tests: change test tag logic #744

merged 1 commit into from
Oct 13, 2025
+64 −28

Conversation

dkropachev
Copy link

@dkropachev dkropachev commented Oct 10, 2025 •
edited
Loading

Main purpose to allow to run tests marked by both CassandraVersion and ScyllaVersion.
Also contains some refactoring that is long time due.

@dkropachev dkropachev force-pushed the dk/3.x-update-test-tagging-logic branch from e79cf03 to 40c67d5 Compare October 10, 2025 14:39
@dkropachev dkropachev force-pushed the dk/3.x-update-test-tagging-logic branch from 40c67d5 to c4cb026 Compare October 13, 2025 15:54
@dkropachev dkropachev marked this pull request as ready for review October 13, 2025 16:44
Bouncheck
Bouncheck approved these changes Oct 13, 2025
View reviewed changes
Copy link

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.
It would be good if there was additionally a test annotated with both so we could easily see if it works on CI.

Personally i think the old approach was easier to read

@dkropachev dkropachev merged commit 819827e into scylladb:scylla-3.x Oct 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bouncheck Bouncheck Bouncheck approved these changes

@nikagra nikagra Awaiting requested review from nikagra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkropachev @Bouncheck