Skip to content

Node properties are immutable #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

Node properties are immutable #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/Report/Xml/Node.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@
*/
abstract class Node
{
private DOMDocument $dom;
private DOMElement $contextNode;
private readonly DOMDocument $dom;
private readonly DOMElement $contextNode;

public function __construct(DOMElement $context)
{
$this->setContextNode($context);
$this->dom = $context->ownerDocument;
$this->contextNode = $context;
}

public function dom(): DOMDocument
Expand Down Expand Up @@ -76,12 +77,6 @@ public function addFile(string $name, string $href): File
return new File($fileNode);
}

protected function setContextNode(DOMElement $context): void
{
$this->dom = $context->ownerDocument;
$this->contextNode = $context;
}

protected function contextNode(): DOMElement
{
return $this->contextNode;
Expand Down