-
Notifications
You must be signed in to change notification settings - Fork 284
Removing IAM authentication from kafka settings #3337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Changes looks good. Make sure to test on stage. We will also have to update tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this assuming no one is using this feature in production
Verification
|
It's not getting used except in one test file link
Tests on stage in not working because I am not able to install actions-cli |
A summary of your pull request, including the what change you're making and why.
Removing iam settings from kafka destination docs because we don't support IAM authentication for Kafka.
https://twilio-engineering.atlassian.net/browse/STRATCONN-6172
Testing
Performed cloud stage deploy https://github.com/segmentio/action-destinations/actions/runs/18278506656, verification pending.
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.