Skip to content

Conversation

mdkhan-tw
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Removing iam settings from kafka destination docs because we don't support IAM authentication for Kafka.

https://twilio-engineering.atlassian.net/browse/STRATCONN-6172

Testing

Performed cloud stage deploy https://github.com/segmentio/action-destinations/actions/runs/18278506656, verification pending.

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@itsarijitray
Copy link
Contributor

Changes looks good. Make sure to test on stage. We will also have to update tests.

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this assuming no one is using this feature in production

@mdkhan-tw
Copy link
Contributor Author

Verification

  1. Check on production db > control plane (config setting table > destination settings)
  2. Check in code if the field is getting used

@mdkhan-tw
Copy link
Contributor Author

mdkhan-tw commented Oct 13, 2025

Verification

  1. Check on production db > control plane (config setting table > destination settings)
ctlplane> select * from destination_config_options_2 where destination_id = '65dde5755698cb0dab09b489' and option_name in ('accessKeyId', 'authorizationIdentity', 'secretAccessKey') and value != '""' limit 20;
+--------------------------+------------------------+--------------------------+-----------------------+---------+-----------+-----------------------------------------------+--------------------------+-----------------+
| config_id                | project_id             | destination_id           | option_name           | enabled | encrypted | value                                         | updated_at               | ifn_instance_id |
+--------------------------+------------------------+--------------------------+-----------------------+---------+-----------+-----------------------------------------------+--------------------------+-----------------+
| 664bd3e4d7aab029091950eb | 7AXRT5vAEqATgYKkJU6KJ3 | 65dde5755698cb0dab09b489 | accessKeyId           | 0       | 0         | "<redacted_string>"                        | 2024-05-23T11:17:56.851Z | <null>          |
| 664bd3e4d7aab029091950eb | 7AXRT5vAEqATgYKkJU6KJ3 | 65dde5755698cb0dab09b489 | secretAccessKey       | 0       | 0         | "<redacted_string>"    | 2024-05-23T11:17:56.851Z | <null>          |
| 6648318a3d0d9ccd849624bc | nzbHP77g4jyrf9DjWrSDFP | 65dde5755698cb0dab09b489 | accessKeyId           | 1       | 0         | "<redacted_string>"                        | 2024-06-03T02:49:58.989Z | <null>          |
| 6648318a3d0d9ccd849624bc | nzbHP77g4jyrf9DjWrSDFP | 65dde5755698cb0dab09b489 | authorizationIdentity | 1       | 0         | "<redacted_string>" | 2024-06-03T02:49:58.989Z | <null>          |
| 6648318a3d0d9ccd849624bc | nzbHP77g4jyrf9DjWrSDFP | 65dde5755698cb0dab09b489 | secretAccessKey       | 1       | 0         | "<redacted_string>"    | 2024-06-03T02:49:58.989Z | <null>          |
+--------------------------+------------------------+--------------------------+-----------------------+---------+-----------+-----------------------------------------------+--------------------------+-----------------+
  1. Check in code if the field is getting used

It's not getting used except in one test file link

Make sure to test on stage.

Tests on stage in not working because I am not able to install actions-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants