Skip to content

Conversation

joe-ayoub-segment
Copy link
Contributor

Criteo Partner wants batching to always be enabled.
This PR turns it on for all new instances of the Integration.
Pre-existing instances will have their setting locked - so Criteo should reach out to their customers to ask them to turn on batching before this PR is deployed.

Testing

None needed. Standard change.

@MarcDillar
Copy link
Contributor

Marc from Criteo here.

@joe-ayoub-segment Thank you for the change. Can't the enable_batching be set as read only at the destination level instead? (/packages/destination-actions/src/destinations/criteo-audiences/index.ts)

@joe-ayoub-segment
Copy link
Contributor Author

joe-ayoub-segment commented Oct 17, 2025 via email

@joe-ayoub-segment joe-ayoub-segment merged commit 0f4dd24 into main Oct 21, 2025
14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the criteo-batching-on branch October 21, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants