Algolia improvements #2350
Open
Algolia improvements #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Don't forget to add
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 3df8255 |
| 🔍 Latest deploy log | https://app.netlify.com/projects/semgrep-docs-prod/deploys/68ed868fa0f9200008aa9ec1 |
| 😎 Deploy Preview | https://deploy-preview-2350--semgrep-docs-prod.netlify.app |
| 📱 Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![semgrep-zcs-prod-semgrep[bot]](https://avatars.githubusercontent.com/u/29760937?s=60&v=4){kind=small}
|
|
||
| // Update the count | ||
| const count = searchResults.length; | ||
| const plural = count === 1 ? 'result' : 'results'; |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Just so you know, we have a JS library that handles pluralization of words. You can call pluralize('word', number) and it'll output either "word" or "words". It understands irregular words, including stuff like "have"/"has".
To resolve this comment:
✨ Commit Assistant Fix Suggestion
- Import the
pluralizelibrary at the top of your file if it's not already imported:import pluralize from 'pluralize'; - Replace the line
const plural = count === 1 ? 'result' : 'results';withconst plural = pluralize('result', count);
This will handle all pluralization logic, including irregular forms, more reliably.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by we_have_a_pluralize_library.
You can view more details about this finding in the Semgrep AppSec Platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we improve Algolia instead of implementing a new search engine?