Skip to content

fix: add HEIC/HEIF MIME type support in normalizeFile #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bang9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add HEIC/HEIF MIME type support in normalizeFile #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/uikit-react-native/src/__tests__/utils/normalizeFile.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ describe('normalizeFile', () => {

const invalidResult = await normalizeFile({ uri: 'uri', size: null, name: 'fromName.pdf', type: 'invalid' });
expect(invalidResult).toStrictEqual({ uri: 'uri', size: 0, name: 'fromName.pdf', type: 'application/pdf' });

const heicResult = await normalizeFile({ uri: 'uri', size: null, name: 'fromName.heic', type: null });
expect(heicResult).toStrictEqual({ uri: 'uri', size: 0, name: 'fromName.heic', type: 'image/heic' });

const heifResult = await normalizeFile({ uri: 'uri', size: null, name: 'fromName.heif', type: null });
expect(heifResult).toStrictEqual({ uri: 'uri', size: 0, name: 'fromName.heif', type: 'image/heif' });
});

it('should get type from uri if name and type are invalid', async () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/uikit-utils/src/shared/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const EXTENSION_MIME_MAP = {
'gif': 'image/gif',
'webp': 'image/webp',
'svg': 'image/svg+xml',
'heic': 'image/heic',
'heif': 'image/heif',

// Video
'3gp': 'video/3gpp',
Expand Down