Skip to content

Conversation

@Thiemann96
Copy link
Collaborator

No description provided.

@mpfeil mpfeil changed the title Add/rainsensor (feat): add hydreon rg15 rainsensor Sep 8, 2023
@mpfeil mpfeil self-requested a review September 8, 2023 06:14
Copy link
Member

@mpfeil mpfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install the hydreon library in Dockerfile so tests can run successfully.

https://github.com/sensebox/node-sketch-templater/blob/main/Dockerfile

Copy link
Member

@mpfeil mpfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thiemann96 could you also add the sensor to the ethernet & lora templates

@Thiemann96
Copy link
Collaborator Author

I added ethernet and lora sketch. I had to add some transformers to the ttn integration which can be seen here sensebox/ttn-osem-integration#51

I cant test that right now, so some feedback would be appreciated

@mpfeil
Copy link
Member

mpfeil commented Sep 14, 2023

@mariopesch @PaulReichmuth could you test the different sketches and provide some feedback please.

@BjoernLuig
Copy link
Contributor

  • added rainsensor and solar charger (with rescaling to uint in lora sketch -> TODO for opensensemap)
  • included compiler error messages in test script
  • moved sds sensor into normal (not "feinstaub") scripts -> TODO for opensensemap, no feinstaub model needed in homev2
  • changed "serialPort" to "sdsSerialPort" and "rg15SerialPort" -> TODO for opensensmap
  • commented out SPS30 because it was only implemented in the wifi template and should not be part of sensebox home
  • testet all changes in docker container

@eric can you check it?

@Thiemann96 Thiemann96 merged commit 9793058 into main Mar 17, 2025
3 checks passed
@Thiemann96 Thiemann96 deleted the add/rainsensor branch March 17, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants