Feature add warning / exception dependning on Gotenberg version #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neirda24
force-pushed
the
feature/warning-version
branch
from
bbd9815 to
3bfbb0d
Compare
StevenRenaux
reviewed
Aug 7, 2025
Jean-Beru
reviewed
Aug 8, 2025
| /** | ||
| * @param '>'|'<'|'>='|'<='|'=' $operator | ||
| */ | ||
| protected function warningIf(string $operator, string|Version $version, string|\Stringable $message): void |
There was a problem hiding this comment.
Suggested change
| protected function warningIf(string $operator, string|Version $version, string|\Stringable $message): void | |
| protected function warnIf(string $operator, string|Version $version, string|\Stringable $message): void |
There was a problem hiding this comment.
hmmmm... I feel warning is closer to the underlying logic.
There was a problem hiding this comment.
I propose to rename this method to describe the action. It can be logWarningIf or just logIf. (but I prefer warnIf 😛 )
Jean-Beru
reviewed
Aug 8, 2025
Jean-Beru
reviewed
Aug 11, 2025
| /** | ||
| * @param '>'|'<'|'>='|'<='|'=' $operator | ||
| */ | ||
| protected function warningIf(string $operator, string|Version $version, string|\Stringable $message): void |
There was a problem hiding this comment.
I propose to rename this method to describe the action. It can be logWarningIf or just logIf. (but I prefer warnIf 😛 )
Jean-Beru
reviewed
Sep 15, 2025
| /** | ||
| * @param '>'|'<'|'>='|'<='|'=' $operator | ||
| */ | ||
| protected function logWarningIfVersionIs(string $operator, string|Version $version, string|\Stringable $message): void |
There was a problem hiding this comment.
Since most of calls are done with a < operator, what about naming it introducedIn like in AbstractBuilder ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description