Feature: Add PhpDoc check #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenRenaux
force-pushed
the
features/Add-phpdoc-links-check
branch
from
1a1aba3 to
081b727
Compare
Neirda24
reviewed
Sep 1, 2025
Neirda24
reviewed
Sep 16, 2025
| $urls = []; | ||
| $files = $this->getFiles(self::DIR_AND_FILES_TO_CHECK); | ||
| foreach ($files as $file) { | ||
| array_push($urls, ...$this->extractUrls($file)); |
There was a problem hiding this comment.
easier way to do this would be to leverage AppendIterator
| array_push($urls, ...$this->extractUrls($file)); | ||
| } | ||
|
|
||
| $urls = array_unique($urls); |
There was a problem hiding this comment.
will not work if using AppendIterator
There was a problem hiding this comment.
Maybe let's keep as array, I prefer to not call multiple times same URL
StevenRenaux
force-pushed
the
features/Add-phpdoc-links-check
branch
from
2dad9d9 to
cf0cbc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need help about dagger implementation