feat: Add flexible PagerDuty configuration via values.yaml or Kubernetes secrets #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes secrets ## Summary This PR adds flexible PagerDuty configuration options to the Sentry Helm chart, allowing users to configure PagerDuty integration either directly through values.yaml or by referencing existing Kubernetes secrets. ## Changes Made ### 1. Enhanced PagerDuty Configuration Options - **Direct Configuration**: Users can now set `pagerduty.appId` directly in values.yaml for simple deployments - **Secret-based Configuration**: Support for `pagerduty.existingSecret` to reference existing Kubernetes secrets containing PagerDuty credentials - **Flexible Secret Key**: Configurable secret key via `pagerduty.existingSecretAppId` (defaults to "app-id") ### 2. Template Updates - **`_helper-sentry.tpl`**: Added logic to handle both configuration methods - Direct appId configuration when no existing secret is specified - Environment variable reference when using existing secrets - **`_helper.tpl`**: Added environment variable injection for secret-based configuration ### 3. Configuration Examples ```yaml # Option 1: Direct configuration pagerduty: appId: "your-pagerduty-app-id" # Option 2: Secret-based configuration pagerduty: existingSecret: "pagerduty-secret" existingSecretAppId: "app-id" # optional, defaults to "app-id" ``` ## Benefits - **Flexibility**: Supports both simple and enterprise-grade deployment patterns - **Security**: Allows sensitive credentials to be managed through Kubernetes secrets - **Backward Compatibility**: Existing configurations continue to work unchanged - **Best Practices**: Follows Helm chart patterns for secret management ## Documentation Updated values.yaml with comprehensive examples and references to Sentry's PagerDuty integration documentation.
bhataprameya
changed the title
|
I don't think the failing test is related to changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds flexible PagerDuty configuration options to the Sentry Helm chart, allowing users to configure PagerDuty integration either directly through values.yaml or by referencing existing Kubernetes secrets.
Changes Made
1. Enhanced PagerDuty Configuration Options
pagerduty.appIddirectly in values.yaml for simple deploymentspagerduty.existingSecretto reference existing Kubernetes secrets containing PagerDuty credentialspagerduty.existingSecretAppId(defaults to "app-id")2. Template Updates
_helper-sentry.tpl: Added logic to handle both configuration methods_helper.tpl: Added environment variable injection for secret-based configuration3. Configuration Examples
Benefits
Documentation
Updated values.yaml with comprehensive examples and references to Sentry's PagerDuty integration documentation.