-
Notifications
You must be signed in to change notification settings - Fork 4
Add Vale to documentation builds #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Justine Geffen <[email protected]>
I'm actively reviewing this. Something in my VS Code isn't working with Vale. I can see it working in the PR, but it's not clear why it's not working locally. I'll investigate as part of the review. |
I suspect it's something that Cursor AI might have done - I have deleted one possibly problematic file. LMK if there are still issues on your side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me locally again. The problems list can be overwhelming, however, I thing it's a huge net improvement and we can assess updating lists and turning things on and off once it's implemented. It's a go ahead from me.
This PR introduces Vale to be used for:
To be added: