-
Notifications
You must be signed in to change notification settings - Fork 4
[PLAT-2774] Launch form query parameter support #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Llewellyn vd Berg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to provide additional info on how the array parameters are handled (configProfiles
, workspaceSecrets
, userSecrets
, labelIds
, resourceLabelsIds
). The multiple values can be provided only in the following way, e.g., ?configProfiles=test1&configProfiles=test2
(by specifying the parameter name multiple times)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise LGTM!
Co-authored-by: Justine Geffen <[email protected]> Signed-off-by: Llewellyn vd Berg <[email protected]>
Only merge once released in Cloud
@netlify /platform-cloud/launch/launchpad#populate-launch-form-with-url-query-parameters