Skip to content

[PLAT-1854] Document dynamic resource labels for Cloud #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 8, 2025

Conversation

llewellyn-sl
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 40334e3
🔍 Latest deploy log https://app.netlify.com/projects/seqera-docs/deploys/6892501484d9c20008cabf6b
😎 Deploy Preview https://deploy-preview-739--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I've included some suggestions for additional clarity.

llewellyn-sl and others added 7 commits July 24, 2025 17:08
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Llewellyn vd Berg <[email protected]>
@atsyganov
Copy link

Hi @llewellyn-sl I am assuming I am looking at the right text here: https://deploy-preview-739--seqera-docs.netlify.app/platform-cloud/resource-labels/overview
Can we possibly add in the section for "Dynamic resource labels" some kind of Table that lost labels and their function. Currently you only mention it inline "...When you provide a variable value (either ${workflowId} or ${sessionId}) in ...."

In M2 we shall be adding more labels and the all we gave to do is to expand teh table with definition.

so for no just a able covering M1 labels, obviously.

Copy link

@swingingsimian swingingsimian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

@justinegeffen justinegeffen added 1. Dev/PM/SME Needs a review by a Dev/PM/SME cloud release labels Jul 25, 2025
@llewellyn-sl llewellyn-sl dismissed swingingsimian’s stale review August 8, 2025 07:25

Requested changes have been addressed.

@llewellyn-sl llewellyn-sl merged commit 4330ee8 into master Aug 8, 2025
7 checks passed
@llewellyn-sl llewellyn-sl deleted the plat-1854-dynamic-resource-labels branch August 8, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Dev/PM/SME Needs a review by a Dev/PM/SME cloud release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants