Skip to content

Make snapshot default spot #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FloWuenne
Copy link
Collaborator

What's Changed

📝 Made Fusion snapshots default - Updated docs and configs to use snapshots as primary approach
🛠️ Added manual queue support - New instructions + launch template for seqerakit manual queues
🔥 Removed up old optional 06_fusion_snapshots/ section

Enhance documentation for Fusion snapshots compute environment and update YAML configurations. Added details on snapshot feature activation and instance type restrictions. Updated README to clarify resource label usage and modified nextflow.config parameters for report generation.
…moves the old 06 section that was an optional testing of Fusion snapshots
…usion launch template

- Added instructions for manual queue usage with seqerakit
- Added launch template for Fusion with ecs agent deactivated from the start
- Added short instructions on how to set launch template for existing CEs (clone CE)
Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - just go and make sure it's not saying "extra Fusion snapshot stuff!" and make it clear snapshots is the default.

workspace: "$ORGANIZATION_NAME/$WORKSPACE_NAME"
credentials: "$AWS_CREDENTIALS"
region: "$AWS_REGION"
work-dir: "$AWS_WORK_DIR"
wave: True
fusion-v2: True
fast-storage: True
snapshots: True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neato burrito


The top-level block `compute-envs` mirrors the `tw compute-envs` command. The `type` and `config-mode` options are seqerakit specific. The nested options in the YAML correspond to options available for the Seqera Platform CLI command. For example, running `tw compute-envs add aws-batch forge --help` shows options like `--name`, `--workspace`, `--credentials`, etc., which are provided to the `tw compute-envs` command via this YAML definition.
You should note it is very similar to the Fusion V2 compute environment, but with the following differences:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense anymore if we're ONLY using Fusion snapshots?


</details>
Note: When setting `snapshots: True`, Fusion, Wave and fast-instance storage will be enabled by default for the CE. We have set these to `true` here for documentation purposes and consistency.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that true or a front end thing? I would rephrase it to be fast storage and Wave are required for Fusion.

| `no-ebs-auto-scale` | `True` | Disables EBS auto-expandable disks (incompatible with Fusion V2) |
| `provisioning-model` | `"SPOT"` | Selects cost-effective spot pricing model |
| `instance-types` | `"c6id,m6id,r6id"` | Selects 6th generation Intel instance types with high-speed local storage |
| `instance-types` | `"c6id.4xlarge,c6id.8xlarge,`<br>`r6id.2xlarge,m6id.4xlarge,`<br>`c6id.12xlarge,r6id.4xlarge,`<br>`m6id.8xlarge"` | Selects instance types with a small enough memory footprint and fast enough network to snapshot the machine within the time limit imposed by AWS during a spot reclamation event. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `instance-types` | `"c6id.4xlarge,c6id.8xlarge,`<br>`r6id.2xlarge,m6id.4xlarge,`<br>`c6id.12xlarge,r6id.4xlarge,`<br>`m6id.8xlarge"` | Selects instance types with a small enough memory footprint and fast enough network to snapshot the machine within the time limit imposed by AWS during a spot reclamation event. |
| `instance-types` | `"c6id.4xlarge,c6id.8xlarge,`<br>`r6id.2xlarge,m6id.4xlarge,`<br>`c6id.12xlarge,r6id.4xlarge,`<br>`m6id.8xlarge"` | Selects instance types with small memory and fast network to snapshot within AWS's time limit during spot reclamation. |

| `max-cpus` | `1000` | Sets maximum number of CPUs for this compute environment |

These options ensure your Fusion V2 compute environment is optimized for performance and cost-effectiveness.
These options ensure your Fusion V2 compute environment is optimized for compatibility with the snapshot feature.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These options ensure your Fusion V2 compute environment is optimized for compatibility with the snapshot feature.
These options ensure your Fusion V2 compute environment is optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants