Adds feature to exclude files from source #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
reviewed
Feb 16, 2022
Member
at-wat
left a comment
at-wat
left a comment
There was a problem hiding this comment.
@nickschuch Thank you for your PR!
I think it's better to make the exclude rule definition more generic by specifying filter func (path string) bool instead of a pattern string, so that users can use not only glob but regexp, complete match and any other custom filter.
What would be the next steps for merging? Where would you like me to contribute tests?
Yes! Please add some tests to ensure it works as expected and won't be broken in future.
|
@nickschuch I need this feature. Are you continue working on this PR? If not, can I do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to exclude paths using globbing.
What would be the next steps for merging? Where would you like me to contribute tests?