Skip to content

Implement FromStr for Map<String, Value> #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mickvangelderen
Copy link

My use case is to enable:

    #[cfg_attr(feature = "clap", arg(long))] // <- clap requires one of From<OsString>, ... , FromStr
    #[cfg_attr(feature = "serde", serde(default))]
    pub whatever: Option<serde_json::Map<String, serde_json::Value>>,

I could write a value_parser for clap:

fn parse_json_object(s: &str) -> Result< serde_json::Map<String, serde_json::Value>, String> {
    serde_json::from_str(s).map_err(|error| error.to_string())
}

But that probably isn't doing the best job with respect to error formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant