Skip to content

Remove lowLatency from Linux specific PortStatus #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove lowLatency from Linux specific PortStatus #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/linux.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ export interface LinuxOpenOptions extends OpenOptions {
// * @param {Boolean} [options.lowLatency=false] flag for lowLatency mode on Linux
}

export interface LinuxPortStatus extends PortStatus {
lowLatency: boolean
}

export interface LinuxSetOptions extends SetOptions {
/** Low latency mode */
lowLatency?: boolean
Expand Down Expand Up @@ -172,7 +168,7 @@ export class LinuxPortBinding implements BindingPortInterface {
await asyncUpdate(this.fd, options)
}

async set(options: LinuxSetOptions): Promise<void> {
async set(options: SetOptions): Promise<void> {
if (!options || typeof options !== 'object' || Array.isArray(options)) {

throw new TypeError('"options" is not an object')
Expand All @@ -184,7 +180,7 @@ export class LinuxPortBinding implements BindingPortInterface {
await asyncSet(this.fd, options)
}

async get(): Promise<LinuxPortStatus> {
async get(): Promise<PortStatus> {
debug('get')
if (!this.isOpen) {
throw new Error('Port is not open')
Expand Down