fix for importing version from package.json, on globally installed in Windows 11 #3070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed using
npm install -g @serialport/terminalaka globally on Windows 11, it is unable to find the path needed to read the version inpackage.json.readFileSync()when ran as a globally installed package, it is unable to find the current working directory as it considers current terminal directory as base. So../package.jsonis being read asC:\Users\package.json, which does not exist, when it is supposed to read relative to its current folder aka hereC:\Users\callum\AppData\Local\nvm\v22.17.1\node_modules\@serialport\list\package.json.The fix is to use a path resolution resolver that works globally, while following ES Modules.