Skip to content

Mark border-color and border-radius as repaint #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Mark border-color and border-radius as repaint #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions style/properties/longhands/border.mako.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
logical_group="border-color",
allow_quirks="No" if is_logical else "Yes",
ignored_when_colors_disabled=True,
servo_restyle_damage="repaint",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For collapsed table borders, the color is resolved during layout. So I don't think this will work

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... we should probably change that (presumably by resolving the source of the color in layout but not the actual color) because changing border-color of e.g. a button on :hover or :active is pretty common and we really don't want to be re-running layout for that.

affects="paint",
)}

Expand Down Expand Up @@ -78,6 +79,7 @@
boxed=True,
logical_group="border-radius",
logical=is_logical,
servo_restyle_damage="repaint",
affects="paint",
)}
% endfor
Expand Down