Allow show password #1948
Closed
Allow show password #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
DO NOT MERGE. Succeeded by gregkorossy/Android-Support-Preference-V7-Fix#182. |
Contributor
Author
|
@madeye Do you think this feature would be a good addition at all? |
Contributor
|
Maybe not, as the password would not be readable at all. |
Contributor
Author
|
Okay. |
Contributor
Author
|
@madeye Hmm, why would the password be not readable? |
Contributor
Author
|
@madeye I'm considering reviving this PR. Currently the profiles can already be exported so I don't see why we need to hide the password. |
Contributor
|
I think we need to hide password by default, as a best practice. Showing password would be useful, but optional. |
Mygod
added a commit
to Mygod/shadowsocks-android
that referenced
this pull request
Feb 12, 2019
Also allows show password. See also shadowsocks#1948.
bannedbook
pushed a commit
to bannedbook/SpeedUp.VPN
that referenced
this pull request
Dec 25, 2019
Also allows show password. See also shadowsocks#1948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.