Skip to content

[Generator] Add react-dom to devDeps #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rguarascia
Copy link

@rguarascia rguarascia commented Jun 22, 2025

When trying the starter command pnpm create jsx-email and selecting Typescript, the project fails to run. Adding react-dom fixes this issue

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Current test pass.

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

While running $ pnpm create jsx-email, after successful creation of a project and installing packages via pnpm i running the project with pnpm dev there is an error in the console which prevents the dev env from running. Adding react-dom to the package.json fixed this issue.

Uncaught TypeError: can't access property "ReactCurrentDispatcher", ReactSharedInternals is undefined
    React 2
    __require http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/chunk-BUSYA2B4.js?v=cc0c0df6:3
    dom React
    __require http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/chunk-BUSYA2B4.js?v=cc0c0df6:3
    dom React
    __require http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/chunk-BUSYA2B4.js?v=cc0c0df6:3
    <anonymous> http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/react-dom_client.js?v=189c18a4:38
[react-dom.development.js:994:30](http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/[email protected][email protected]/node_modules/react-dom/cjs/react-dom.development.js)
    React 2
    __require chunk-BUSYA2B4.js:3
    js React
    __require chunk-BUSYA2B4.js:3
    js React
    __require chunk-BUSYA2B4.js:3
    <anonymous> react-dom_client.js:38

When trying the starter command `pnpm create jsx-email` and selecting `Typescript`, the project fails to run. Adding react-dom fixes this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant