Skip to content

Conversation

@hasanawad94
Copy link
Contributor

@hasanawad94 hasanawad94 commented Oct 26, 2025

Changes

Enable readOnlyFs for strategies and add volumes.

Fixes #1969

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Pointed writes to volumes and enabled readOnlyRootFilesystem in buildah,buildkit, and ko strategies.

@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 26, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2025
@openshift-ci openshift-ci bot requested review from adambkaplan and rxinui October 26, 2025 09:17
@hasanawad94 hasanawad94 marked this pull request as draft October 26, 2025 09:17
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2025
@hasanawad94 hasanawad94 force-pushed the buildah-readonlyfs branch 14 times, most recently from b87e418 to d60471b Compare October 29, 2025 12:33
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2025
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@hasanawad94 hasanawad94 force-pushed the buildah-readonlyfs branch 4 times, most recently from 7aebfb1 to 157b836 Compare October 30, 2025 09:54
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2025
@hasanawad94 hasanawad94 force-pushed the buildah-readonlyfs branch 5 times, most recently from 484ce9a to 95458d0 Compare October 30, 2025 15:24
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2025
@hasanawad94 hasanawad94 force-pushed the buildah-readonlyfs branch 3 times, most recently from ee0bb95 to 084fe58 Compare November 2, 2025 09:23
@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note and removed release-note-none Label for when a PR does not need a release note labels Nov 2, 2025
@hasanawad94 hasanawad94 marked this pull request as ready for review November 2, 2025 09:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2025
added volumes to buildah,buildkit, and ko strategies.
enabled readOnlyRootFilesystem securityContext config.

Signed-off-by: Hasan Awad <[email protected]>
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.18.0 milestone Nov 3, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7d65989 into shipwright-io:main Nov 3, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEATURE] Use readOnlyRootFilesystem in Build Pods

2 participants